Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Symbolic-name and version attribute to jar manifest to support… #1169

Closed
wants to merge 1 commit into from
Closed

Adding Symbolic-name and version attribute to jar manifest to support… #1169

wants to merge 1 commit into from

Conversation

koreykiran
Copy link

… OSGI bundles.

Description

I have added two more attributes to the manifest creation part for the jar file to support OSGI bundles.
Relates to the issue: #1155

@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #1169 into master will increase coverage by 0.003%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #1169       +/-   ##
===============================================
+ Coverage     68.354%   68.357%   +0.003%     
- Complexity      8003      8004        +1     
===============================================
  Files            541       541               
  Lines          32674     32674               
  Branches        5531      5531               
===============================================
+ Hits           22334     22335        +1     
  Misses          8115      8115               
+ Partials        2225      2224        -1
Impacted Files Coverage Δ Complexity Δ
...va/htsjdk/samtools/sra/SRAIndexedSequenceFile.java 64.865% <0%> (+2.703%) 7% <0%> (+1%) ⬆️

@koreykiran koreykiran closed this Jul 27, 2018
@koreykiran koreykiran deleted the kk-symbolic-name branch July 27, 2018 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants