Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #268: System endiannes and unaligned memory access issues on mips #270

Closed
wants to merge 1 commit into from

Conversation

azlicic
Copy link

@azlicic azlicic commented Aug 15, 2014

Turns out that the issue I reported is mostly contained within htslib.
This patch only fixes two input test files (that is, in case I'm right about tag values being out of range).

@jmarshall
Copy link
Member

This patch is incorrect.

In auxiliary fields, SAM can represent arbitrarily large integers (because it is free text) and BAM can represent integers from -2^31 (as type i) to +2^32 - 1 (as type I). So this samtools test case is testing that conversion from SAM to BAM uses type i or type I as appropriate to represent the value present.

(You might not guess this from the SAM spec, which is written more conservatively for the benefit of Java people who don't believe in unsigned...)

@jmarshall jmarshall closed this Sep 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants