-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Dual Assay Seurat Object error #118
Comments
Hi, Thanks for kind words! Can you post the following:
Thanks! |
Thanks Sam,
I guess this is where one issue may lie. However when i read in data using the following: then i get the following: But still get "No cell names (colnames) names present in the input matrix" when combining this file with CreateSeuratObject Thanks |
Hi Duncan, Give this a try. Instead of using |
Hi Sam, I do not think that solves issue. Read10x_h5_GEO makes a list which cannot be read into CreateAssayObject or CreateSeuratObject. Thanks, Duncan |
Hi Duncan, Sorry yes that list can be merged but I missed that you tried with just Read10X. So even with Read10X and CreateSeuratObject just in Seurat alone you still get the error? Best, |
Hi Sam, Yes, when I use Read10x for the cell ranger data I get the following error: Filtering Cell Bender matrix for cells present in raw counts matrix. Thanks |
Hi Duncan, Ok so just clarifying things looking back at your original code. When you read in CellBender data you have 2 samples WT1 and WT2 but when you read in Cell Ranger data you only specified WT1. Is there another file with WT2 from cell ranger? The Dual assay function is meant to create object with overlapping cells. I'm wondering if the issue is actually with overlapping cells given that error. When you read in the cell bender files and merge them it appends the sample ID as barcode prefix to retain unique barcodes per sample. However, when you just read in via
Best, |
Thanks Sam, I have read both ( filtered and unfiltered) cell ranger and cell bender files. And assigned samples names to each file.
Filtering Cell Bender matrix for cells present in raw counts matrix. Any further ideas? Thanks |
Hey Duncan, Thanks for trying that. Are you able to share cell bender and cell ranger files? I have some other ideas but might be easier if I can examine the files directly. If you can share please send me email samuel.marsh@childrens.harvard.edu and I will share link to Google drive folder for upload. Best, |
Hi Duncan, Thanks again for sharing the files and glad to say the issue turned out to straightforward fix. There is now a fix deployed in The issue was due to the fact that feature matrices from both cell ranger and cell bender had underscores in feature names which Seurat doesn't allow: The way the function was originally written it:
So when Seurat changed the feature names upon import the subsequent subsetting of other dgCMatrix was failing because the names weren't present. I have updated the function to avoid this issue and it worked as expected testing on your files. If you continue to have any issues creating object after updating to the develop branch please let me know! Best, |
Hi Sam,
Amazing! Thank you so much again. Can confirm working at my end.
Have a great day.
BW
Duncan
…________________________________
From: Samuel Marsh ***@***.***>
Sent: 03 August 2023 14:46
To: samuel-marsh/scCustomize ***@***.***>
Cc: Duncan Rutherford ***@***.***>; Author ***@***.***>
Subject: Re: [samuel-marsh/scCustomize] Create Dual Assay Seurat Object error (Issue #118)
This email was sent to you by someone outside the University.
You should only click on links or attachments if you are certain that the email is genuine and the content is safe.
Hi Duncan,
Thanks again for sharing the files and glad to say the issue turned out to straightforward fix. There is now a fix deployed in develop branch v1.1.3.9003.
The issue was due to the fact that feature matrices from both cell ranger and cell bender had underscores in feature names which Seurat doesn't allow: Warning: Feature names cannot have underscores ('_'), replacing with dashes ('-').
The way the function was originally written it:
* Created object from CellBender matrix and filtered by min.cell & min.features
* Extracted cell and feature names
* Subsetted Cell Ranger dgCMatrix
* Created Cell Ranger Assay Object
* Added assay to CellBender object
So when Seurat changed the feature names upon import the subsequent subsetting of other dgCMatrix was failing because the names weren't present. I have updated the function to avoid this issue and it worked as expected testing on your files.
If you continue to have any issues creating object after updating to the develop branch please let me know!
Best,
Sam
—
Reply to this email directly, view it on GitHub<#118 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A66VJ5MQ5CVRTKLNEPU5BUDXTOTUBANCNFSM6AAAAAA273IOUQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.
|
Hi Sam,
You really have created a wonderful resource here, thank you so much!
I am having issues with creating the dual assay Seurat object after running CellBender.
I have created two merged matrix's cell_bender and cell_ranger, but when I "CreateAssayObject" I get the following error:
Error in CreateAssayObject(counts = counts, min.cells = min.cells, min.features = min.features, :
No cell names (colnames) names present in the input matrix
Any help would be gratefully received!
Thanks
Duncan
sessionInfo() output
The text was updated successfully, but these errors were encountered: