Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Automatic light/dark theme setting #1379

Closed
samuelclay opened this issue Oct 16, 2020 · 3 comments
Closed

Android: Automatic light/dark theme setting #1379

samuelclay opened this issue Oct 16, 2020 · 3 comments
Labels
android medium

Comments

@samuelclay
Copy link
Owner

Correspond with the system theme. On iOS, we have an auto setting, pictured here:

IMG_7903554BBEEC-1

From https://forum.newsblur.com/t/ui-suggestions-for-the-android-client/8401
@samuelclay
Copy link
Owner Author

Oh the user also mentioned that the bottom bar is white even in dark mode sometimes. Not sure what that's about but we should fix that.

@sictiru
Copy link
Collaborator

sictiru commented Oct 16, 2020

The OS based auto theme has been recently built but it might still be in the beta versions.
I will check the bottom bar theme because based on the phone's manufacturer/OS it might need explicit coding.

sictiru added a commit to sictiru/NewsBlur that referenced this issue Oct 24, 2020
@sictiru
samuelclay#1379 Automatic light/dark theme
869ee11
@sictiru
Copy link
Collaborator

sictiru commented Oct 24, 2020 •
edited
Loading

I changed the default theme setting to Auto instead of Light to apply the global OS setting out of the box.

@samuelclay For the bottom navigation bar I couldn't find a solution that works well with the current deprecated theme on all API versions. This can be easily fixed after updating the theme, something that I also mentioned here #1353. Created #1381 as a separate issue for that and will start on it soon

samuelclay added a commit that referenced this issue Nov 17, 2020
@samuelclay
Merge branch 'sictiru'
7de6dc8 
* sictiru:
  Android v10.1.1.
  Fix exception
  Update dependencies
  #1380 Use image proxy only for http images
  #1379 Automatic light/dark theme
  #1367 Starred stories service
samuelclay added a commit that referenced this issue Nov 23, 2020
@samuelclay
Merge branch 'master' into django1.11
1504ef7 
* master:
  Checking the 'credit' field if author not found. Works for TechRepublic, which I suspect is a one off.
  Handling multiple newsletter feeds.
  Attempting a fix of stories taking too long to sort while counting unreads.
  Fixing newsletter search.
  Fixing newsletter search.
  Newsletters feeds now de-duplicate based on sender email as well as sender name. This should cut down on duplicates.
  Android v10.1.1.
  Fix exception
  Update dependencies
  #1380 Use image proxy only for http images
  #1379 Automatic light/dark theme
  #1367 Starred stories service
samuelclay added a commit that referenced this issue Nov 30, 2020
@samuelclay
Merge branch 'master' into django1.6
cab6e9d 
* master:
  Fixing DB Monitor.
  Updating User Agent for all fetchers.
  Ignoring VSCode.
  Checking the 'credit' field if author not found. Works for TechRepublic, which I suspect is a one off.
  Handling multiple newsletter feeds.
  Attempting a fix of stories taking too long to sort while counting unreads.
  Fixing newsletter search.
  Fixing newsletter search.
  Newsletters feeds now de-duplicate based on sender email as well as sender name. This should cut down on duplicates.
  Android v10.1.1.
  Ignoring cache for homepage user.
  Gotta recreate empty_values somehow
  Fix exception
  Update dependencies
  #1380 Use image proxy only for http images
  #1379 Automatic light/dark theme
  #1367 Starred stories service
samuelclay added a commit that referenced this issue Nov 30, 2020
@samuelclay
Merge branch 'django1.6' into django1.7
8ee277c 
* django1.6:
  Fixing DB Monitor.
  Updating User Agent for all fetchers.
  Ignoring VSCode.
  Checking the 'credit' field if author not found. Works for TechRepublic, which I suspect is a one off.
  Handling multiple newsletter feeds.
  Attempting a fix of stories taking too long to sort while counting unreads.
  Fixing newsletter search.
  Fixing newsletter search.
  Newsletters feeds now de-duplicate based on sender email as well as sender name. This should cut down on duplicates.
  Android v10.1.1.
  Ignoring cache for homepage user.
  Gotta recreate empty_values somehow
  Fix exception
  Update dependencies
  #1380 Use image proxy only for http images
  #1379 Automatic light/dark theme
  #1367 Starred stories service
samuelclay added a commit that referenced this issue Nov 30, 2020
@samuelclay
Merge branch 'django1.7' into django1.8
4bd9a6d 
* django1.7:
  Fixing DB Monitor.
  Updating User Agent for all fetchers.
  Ignoring VSCode.
  Checking the 'credit' field if author not found. Works for TechRepublic, which I suspect is a one off.
  Handling multiple newsletter feeds.
  Attempting a fix of stories taking too long to sort while counting unreads.
  Fixing newsletter search.
  Fixing newsletter search.
  Newsletters feeds now de-duplicate based on sender email as well as sender name. This should cut down on duplicates.
  Android v10.1.1.
  Ignoring cache for homepage user.
  Gotta recreate empty_values somehow
  Fix exception
  Update dependencies
  #1380 Use image proxy only for http images
  #1379 Automatic light/dark theme
  #1367 Starred stories service
samuelclay added a commit that referenced this issue Nov 30, 2020
@samuelclay
Merge branch 'django1.8' into django1.9
55f278d 
* django1.8:
  Fixing DB Monitor.
  Updating User Agent for all fetchers.
  Ignoring VSCode.
  Checking the 'credit' field if author not found. Works for TechRepublic, which I suspect is a one off.
  Handling multiple newsletter feeds.
  Attempting a fix of stories taking too long to sort while counting unreads.
  Fixing newsletter search.
  Fixing newsletter search.
  Newsletters feeds now de-duplicate based on sender email as well as sender name. This should cut down on duplicates.
  Android v10.1.1.
  Ignoring cache for homepage user.
  Gotta recreate empty_values somehow
  Fix exception
  Update dependencies
  #1380 Use image proxy only for http images
  #1379 Automatic light/dark theme
  #1367 Starred stories service
samuelclay added a commit that referenced this issue Nov 30, 2020
@samuelclay
Merge branch 'django1.9' into django1.10
61e6043 
* django1.9:
  Fixing DB Monitor.
  Updating User Agent for all fetchers.
  Ignoring VSCode.
  Checking the 'credit' field if author not found. Works for TechRepublic, which I suspect is a one off.
  Handling multiple newsletter feeds.
  Attempting a fix of stories taking too long to sort while counting unreads.
  Fixing newsletter search.
  Fixing newsletter search.
  Newsletters feeds now de-duplicate based on sender email as well as sender name. This should cut down on duplicates.
  Android v10.1.1.
  Ignoring cache for homepage user.
  Gotta recreate empty_values somehow
  Fix exception
  Update dependencies
  #1380 Use image proxy only for http images
  #1379 Automatic light/dark theme
  #1367 Starred stories service
@sictiru sictiru closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samuelclay @sictiru