Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow executing dependency to be >1.0.0 #115

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

staticf0x
Copy link
Contributor

Closes #114

I just tested it with executing==1.2.0 and asttokens==2.1.0 and everything seems to work, the tests pass.

This will allow users to update executing to a version greater than 1.0.0, for example in the case of global installation.

Please let me know if there is anything that would prevent this change from being possible. I checked the executing's API and there wasn't any breaking change.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #115 (42cd3a8) into main (5efff5f) will not change coverage.
The diff coverage is n/a.

❗ Current head 42cd3a8 differs from pull request most recent head 2273b5c. Consider uploading reports for the commit 2273b5c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #115    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            7         4     -3     
  Lines          522       279   -243     
  Branches        86        44    -42     
==========================================
- Hits           522       279   -243     
Impacted Files Coverage Δ
devtools/prettier.py
devtools/__init__.py
devtools/utils.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5efff5f...2273b5c. Read the comment docs.

@alexmojaki
Copy link
Contributor

I'd actually recommend requiring executing>=1.1.1, especially for Python 3.11.

@samuelcolvin
Copy link
Owner

Then let's uprev. And require that.

@staticf0x
Copy link
Contributor Author

Thanks for your comments! So >=1.1.1,<2.0.0 would work here?

@samuelcolvin
Copy link
Owner

Let's not put in upper bounds unless there's a specific reason to.

@samuelcolvin samuelcolvin merged commit ba0507a into samuelcolvin:main Nov 25, 2022
@samuelcolvin
Copy link
Owner

thanks so much.

@samuelcolvin
Copy link
Owner

@alexmojaki @staticf0x anything else important, or shall I make a release?

I really want #105, #116 and #117 but I don't have time to work on them ATM., so unless someone else is keen, maybe best to release what we have on main now?

@staticf0x staticf0x deleted the bump-executing branch November 25, 2022 10:52
@alexmojaki
Copy link
Contributor

I don't see any reason to wait to release.

@staticf0x
Copy link
Contributor Author

staticf0x commented Nov 25, 2022

I would be interested in working on #105 and #116 but I won't have time anytime soon, so perhaps next release?

@samuelcolvin
Copy link
Owner

Great, thanks. Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deps to support executing >= 1.0.0
3 participants