-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow executing dependency to be >1.0.0 #115
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 7 4 -3
Lines 522 279 -243
Branches 86 44 -42
==========================================
- Hits 522 279 -243
Continue to review full report at Codecov.
|
I'd actually recommend requiring executing>=1.1.1, especially for Python 3.11. |
Then let's uprev. And require that. |
Thanks for your comments! So |
Let's not put in upper bounds unless there's a specific reason to. |
thanks so much. |
@alexmojaki @staticf0x anything else important, or shall I make a release? I really want #105, #116 and #117 but I don't have time to work on them ATM., so unless someone else is keen, maybe best to release what we have on |
I don't see any reason to wait to release. |
Great, thanks. Agreed. |
Closes #114
I just tested it with
executing==1.2.0
andasttokens==2.1.0
and everything seems to work, the tests pass.This will allow users to update
executing
to a version greater than1.0.0
, for example in the case of global installation.Please let me know if there is anything that would prevent this change from being possible. I checked the
executing
's API and there wasn't any breaking change.