Refactoring the template.schedule module #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelduchesne
added
the
refactoring
No idf file path needed
… a later version was specified
No need to specify "ep_object" and "kwargs" in dictionary of new id object. Just pass a dict with {key="OBJECT_KEY", **kwargs}, where kwargs is the field=value names
…stance instead. Fixes issues with parallel processing
…for OpaqueMaterials
…d to read the IDF This prevents the newidfobject method to modify the IDF file which in turn changed the simulation_dir
…ent in tqdm (for parallel process)
Possible to call the debug option in the cli with the -d option. Will break on any raised exception.
Uses get_referenced_object instead of looping though validobjects
Gas properties are taken from the literature
Uses the simulation Zone Summary instead
hopefully, this is quicker
samuelduchesne
force-pushed
the
feature/ScheduleRefactor
branch
from
08182d1
to
08ca913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request intends to refactor the template.schedule module which merits a proper makeover as it was one of the first modules to be created.