Skip to content
This repository has been archived by the owner on Jul 12, 2021. It is now read-only.

Crash when deleting lines #45

Closed
dmg59 opened this issue Dec 8, 2019 · 6 comments
Closed

Crash when deleting lines #45

dmg59 opened this issue Dec 8, 2019 · 6 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@dmg59
Copy link

dmg59 commented Dec 8, 2019

Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at ga (file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:37:77609)
    at Ia (file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:37:81585)
    at Wa (file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:37:84902)
    at file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:37:98278
    at Object.t.unstable_runWithPriority (file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:45:3218)
    at Es (file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:37:98213)
    at Ts (file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:37:97989)
    at Ds (file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:37:97334)
    at Ps (file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:37:98709)
    at Dn (file:///Applications/Mini%20Diary.app/Contents/Resources/app.asar/bundle/renderer.js:37:30567)

Mini Diary 2.4.1
Electron 5.0.8
darwin 19.0.0
Locale: en-GB

@samuelmeuli
Copy link
Owner

@dmg59 Could you please provide more information? When does this error occur?

@samuelmeuli samuelmeuli added the bug Something isn't working label Dec 8, 2019
@dmg59
Copy link
Author

dmg59 commented Dec 8, 2019 via email

@samuelmeuli samuelmeuli changed the title crashed Crash when deleting text Dec 8, 2019
@samuelmeuli
Copy link
Owner

This seems to be related to Draft.js; it might be this issue: facebookarchive/draft-js#1320

@dmg59 Have you been able to reproduce the error?

@samuelmeuli
Copy link
Owner

I've applied the workaround mentioned in facebookarchive/draft-js#1320. Please let me know if this issue still occurs after the next Mini Diary release :)

@samuelmeuli samuelmeuli changed the title Crash when deleting text Crash when deleting lines Dec 8, 2019
@dmg59
Copy link
Author

dmg59 commented Dec 8, 2019 via email

@samuelmeuli
Copy link
Owner

This workaround unfortunately introduced an auto-scrolling bug (#47). I've reverted it as I consider the other problem more severe, and this issue should be fixed in Draft.js instead.

@samuelmeuli samuelmeuli added the wontfix This will not be worked on label Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants