This repository has been archived by the owner on Jul 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 233
Crash when deleting lines #45
Comments
@dmg59 Could you please provide more information? When does this error occur? |
I wanted to delete a few lines and it just crashed
Diana Gariany
dmgariany@icloud.com
Skype: dghariany59
Twitter:@DGhariany
Facebook:diana.ghariany
… On 8 Dec 2019, at 5:38 PM, Samuel Meuli ***@***.***> wrote:
@dmg59 <https://github.com/dmg59> Could you please provide more information? When does this error occur?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#45?email_source=notifications&email_token=AE3I7T27ZJQJOKYJ2FHRDU3QXUIGXA5CNFSM4JX4XLU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGHBUZI#issuecomment-562960997>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE3I7T64766OF4T4MRJUZOTQXUIGXANCNFSM4JX4XLUQ>.
|
This seems to be related to Draft.js; it might be this issue: facebookarchive/draft-js#1320 @dmg59 Have you been able to reproduce the error? |
I've applied the workaround mentioned in facebookarchive/draft-js#1320. Please let me know if this issue still occurs after the next Mini Diary release :) |
Ok
Diana Gariany
dmgariany@icloud.com
Skype: dghariany59
Twitter:@DGhariany
Facebook:diana.ghariany
… On 8 Dec 2019, at 8:48 PM, Samuel Meuli ***@***.***> wrote:
I've applied the workaround mentioned in facebookarchive/draft-js#1320 <facebookarchive/draft-js#1320>. Please let me know if this issue still occurs after the next Mini Diary release :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#45?email_source=notifications&email_token=AE3I7T2Q3Y4U32MACRNZHYDQXU6PBA5CNFSM4JX4XLU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGHGINY#issuecomment-562979895>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE3I7T6YMKQ3M7V2XBHRWNTQXU6PBANCNFSM4JX4XLUQ>.
|
This workaround unfortunately introduced an auto-scrolling bug (#47). I've reverted it as I consider the other problem more severe, and this issue should be fixed in Draft.js instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Mini Diary 2.4.1
Electron 5.0.8
darwin 19.0.0
Locale: en-GB
The text was updated successfully, but these errors were encountered: