Add alphabetical sort to file manager #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
force-pushed
the
fm-alphasort#929
branch
from
c9cc685
to
acf6da6
Compare
hackartisan
changed the title
| } | ||
|
|
||
| initialize_alpha_sort_button() { | ||
| Blacklight.onLoad(() => { |
There was a problem hiding this comment.
I don't think the sorting manager gets triggered until Blacklight's loaded, so this shouldn't be necessary.
There was a problem hiding this comment.
Actually you're right and this was causing a bug that I hadn't noticed where the button didn't work unless you reload the page.
hackartisan
force-pushed
the
fm-alphasort#929
branch
from
acf6da6
to
eb95157
Compare
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my approach; any comments, @tpendragon or @jcoyne ?
Thanks!