Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share listing has check boxes but no buttons #2419

Closed
carolyncole opened this issue Aug 9, 2016 · 4 comments
Closed

Share listing has check boxes but no buttons #2419

carolyncole opened this issue Aug 9, 2016 · 4 comments
Assignees
@jcoyne
Labels
blocker bug user interface
Milestone
7.3.0

Comments

@carolyncole
Copy link
Contributor

carolyncole commented Aug 9, 2016 •
edited by mtribone

Descriptive summary

In Sufia 7 the shares tab includes check boxes for batch editing, but does not include buttons. Sufia 6 used to allow edit, but not delete for shared files?

Expected behavior

When I check a box next to a shared item
Then I should see an Edit button at the top of the page

screen shot 2016-08-09 at 12 04 24 pm

Actual behavior

When I click the box the sort options disappear, but no button appears

screen shot 2016-08-09 at 12 00 00 pm

Steps to reproduce the behavior

When I have Works Shared with me by another user
And I click on the check box next to a shared work
Then I should see the Edit button, but I do not...

Related work

#2418 The tab has the wrong name...
@carolyncole
Copy link
Contributor Author

Same problem on My Highlights
screen shot 2016-08-09 at 12 12 09 pm

@mjgiarlo mjgiarlo added this to the 7.2.0 milestone Aug 9, 2016
@mjgiarlo mjgiarlo removed the ready label Sep 6, 2016
@carolyncole
Copy link
Contributor Author

This is also an issue with My Highlights.

@jcoyne jcoyne modified the milestones: 7.2.0, 7.3.0 Oct 7, 2016
@mtribone mtribone assigned mtribone and unassigned mtribone Dec 5, 2016
@mtribone mtribone mentioned this issue Dec 8, 2016
Closed
@jcoyne jcoyne self-assigned this Jan 23, 2017
@jcoyne
Copy link
Contributor

jcoyne commented Jan 23, 2017

I don’t see how this ever worked given this change 3 years ago. 9411a12
AFACT, it only ever showed “Edit Selected” when on my/files controller.

@jcoyne
Copy link
Contributor

jcoyne commented Jan 23, 2017

I think this is a difference between Scholarsphere and Sufia: https://github.com/psu-stewardship/scholarsphere/blob/develop_s6/app/views/my/_sort_and_per_page.html.erb#L6-L16

jcoyne added a commit that referenced this issue Jan 23, 2017
@jcoyne
Display edit button when checking boxes on shared works tab
1b45676 
Patched in the code that Scholarsphere was using on its
sort_and_per_page partial
Fixes #2419
@jcoyne jcoyne mentioned this issue Jan 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcoyne jcoyne

Labels
blocker bug user interface
Projects
None yet
Milestone
7.3.0
Development

No branches or pull requests
4 participants
@jcoyne @mjgiarlo @carolyncole @mtribone