Adding a surveyor to create survey items for an id list #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # @param [Array] id_list a list of ids to be surveyed | ||
| def call(id_list) | ||
| ActiveFedora::Base.find(id_list).each do |object| | ||
| Item.create(object_id: object.id, object_class: object.class, object_title: object.title, migration_status: -1) |
There was a problem hiding this comment.
It seems that meaning has been encoded in migration_status, but it's not clear to me what -1 represents.
There was a problem hiding this comment.
Does it make sense to encode this in an ActiveRecord::Enum?
|
@Cam156 needs a rebase. |
And adding enumerator for migration status
| module Sufia | ||
| module Migration | ||
| module Survey | ||
| class Item < ActiveRecord::Base | ||
| enum migration_status: [:initial_state, :successful, :missing, :wrong_type] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2133
Creates a Sufia::Migration::Survey::Item for each id passed into the call. If any id does not exists the entire call should fail.
The id list is generated by the code in #2335.
@projecthydra/sufia-code-reviewers