MediaConvert adapter has direct_output_lookup config, to avoid using CloudWatch #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
circleci does not seem to be kicking off, I don't know how to fix it. :( |
jrochkind
force-pushed
the
alternate_output_determination
branch
from
74c4782
to
2578918
Compare
To calculate output directly from the MediaConvert Job object, without requiring the CloudWatch logs. All the info we were returning is there EXCEPT the actual output URLs. Sufficient info is there to calculate/predict the output URLs though -- I have done that for HLS. I believe it should be do-able for other formats too, but I am not familiar with them to figure out what they should be, so for NOW the URL calculation is only there for HLS. (If it's important, I could try to familiarize myself with the others and how the adapter currently handles them and try to match them without CloudWatch too? Not sure what other outputs are in any actual use at present, if any?) This logic makes some assumptions, like that hteres only one input file and only one output group -- but I _think_ such assumptions were already being made, and the adapter at current is incapable of violating them. It does potentially introduce some additional fragility though.
jrochkind
force-pushed
the
alternate_output_determination
branch
from
2578918
to
2a86c51
Compare
|
I approved this because the PR looks good and the tests passed on my system. It would be great to get them passing in CI as well. |
|
I believe @cjcolvar can make them run somehow. Pretty please then we'll merge after pass? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaConvert adapter has direct_output_lookup config
To calculate output directly from the MediaConvert Job object, without requiring the CloudWatch logs.
(Also includes a commit that renamed some methods/variables for clarity, and added inline comments.)
All the info we were returning is there EXCEPT the actual output URLs. Sufficient info is there to calculate/predict the output URLs though -- I have done that for HLS. I believe it should be do-able for other formats too, but I am no
t familiar with them to figure out what they should be, so for NOW the URL calculation is only there for HLS. (If it's important, I could try to familiarize myself with the others and how the adapter currently handles them and try to match them without CloudWatch too? Not sure what other outputs are in any actual use at present, if any?)
This logic makes some assumptions, like that hteres only one input file and only one output group -- but I think such assumptions were already being made, and the adapter at current is incapable of violating them. It does potentiall
y introduce some additional fragility though.