Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always render annotation resources in Viewer #178

Merged
merged 1 commit into from Mar 11, 2024

Conversation

adamjarling
Copy link
Collaborator

What does this do?

Fixes a bug where Annotation Resources were being hidden when a user configures their Viewer to hide the InformationPanel. For example, say there are VTT files associated with a Video in a canvas, these should always render alongside the content.

image

How to test:

Configure the viewer to hide the InformationPanel, i.e.

<Viewer
  options={{
    canvasHeight: "640px",
    informationPanel: {
      open: false,
      renderAbout: false,
      renderToggle: false,
    },
  }}
/>

If running Clover in a dev environment, use this manifest:

https://api.dc.library.northwestern.edu/api/v2/works/44f70212-029f-44cd-a3b3-03c18b208103?as=iiif

...or any manifest which contains Annotation Resources (doesn't have to be VTT annotations).

@adamjarling adamjarling self-assigned this Mar 11, 2024
@@ -67,7 +67,7 @@ const ViewerContent: React.FC<ViewerContentProps> = ({
</MediaWrapper>
)}
</Main>
{informationOpen && isAside && (
{(informationOpen || isAside) && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamjarling adamjarling merged commit ae8490a into main Mar 11, 2024
1 check passed
@adamjarling adamjarling deleted the 4568-info-panel-vtt-bug branch March 11, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants