Ruby3 support #31
Merged
Ruby3 support #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliotjordan
requested changes
Feb 9, 2024
|
I noticed we're now seeing coveralls errors and a bit of googling seems to indicate that people have switched to coveralls_reborn? I pushed that up to see if CI is happier. |
I noticed when running the tests under Ruby 3.2 that there were some test failures due to changes in YAML.safe_load and how parameters are passed in Ruby3 (hashes passed aren't automatically turned into named parameters by default).
|
@eliotjordan ok, looks like tests are passing now! |
eliotjordan
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this useful library! We use it at Stanford to ingest content into our GeoServer instances.
I noticed when running the tests under Ruby 3.2 that there were some test failures due to changes in YAML.safe_load and how parameters are passed in Ruby3, since hashes are no longer automatically turned into named parameters by default.
I updated the github action to run under ruby 3.3, but I'm not 100% sure it will work until it runs.