Don't track changes or attempt to persist server-managed properties on file metadata nodes #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n file metadata nodes
cjcolvar
force-pushed
the
server_managed_properties
branch
from
eaec0c6
to
ba1098b
Compare
no-reply
reviewed
Jan 12, 2022
| @@ -21,6 +21,6 @@ def self.legacy_ebucore_vocabulary | |||
| property :date_modified, predicate: ::RDF::Vocab::EBUCore.dateModified | |||
| property :byte_order, predicate: SweetJPLTerms.byteOrder | |||
| # This is a server-managed predicate which means Fedora does not let us change it. | |||
| property :file_hash, predicate: ::RDF::Vocab::PREMIS.hasMessageDigest | |||
| property :file_hash, predicate: ::RDF::Vocab::PREMIS.hasMessageDigest, server_managed: true | |||
There was a problem hiding this comment.
i'm really into this pattern. 💯
no-reply
reviewed
Jan 12, 2022
no-reply
approved these changes
Jan 12, 2022
Co-authored-by: tamsin johnson <tomjohnson@ucsb.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream port of monkey-patch in Hyrax required for wings (samvera/hyrax#5320)
This PR introduces an attribute on properties in the metadata schemas called
:server_managed. When this attribute is set to true on a property it allows a value to be set via the generated setter but the change isn't tracked byActiveModel::Dirtyand subsequently isn't sent to the server as part of the changed values when saving.