don't attempt to save AF::WithMetadata::MetadataNode#file_hash #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
file-metadata-wings
branch
from
5eb4a29
to
f0b067b
Compare
no-reply
changed the title
no-reply
force-pushed
the
file-metadata-wings
branch
from
f0b067b
to
b906c82
Compare
|
i'm hoping that the rebase will fix the build. |
|
@cjcolvar do you think it would be a good idea to open an issue on ActiveFedora? the error behind this is easily repeatable there. it might be appropriate to port this monkeypatch upstream, or come up with a more principled fix. |
added 2 commits
January 11, 2022 09:43
one expectation per test; use named rspec subject.
`ActiveFedora::WithMetadata::MetadataNode` provides a `#file_hash` attribute, but writing to it, even with the existing data, prevents all saves. Wings needs to map data in and out of this class freely, and this attribute functions as a honeypot. it baits Wings to preserve the data, and then fails save when the converters try to do keep the existing data. since any attempt to write this data will break save, ActiveFedora should treat it as read only. never include `MetadataNode#file_hash` in changed attributes lists when Wings is loaded.
dunn
approved these changes
Jan 11, 2022
|
@no-reply An upstream fix would probably be a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveFedora::WithMetadata::MetadataNodeprovides a#file_hashattribute,but writing to it, even with the existing data, prevents all saves.
Wings needs to map data in and out of this class freely, and this attribute
functions as a honeypot. it baits Wings to preserve the data, and then fails
save when the converters try to do keep the existing data. since any attempt to
write this data will break save, ActiveFedora should treat it as read only.
never include
MetadataNode#file_hashin changed attributes lists when Wings isloaded.
i think this is the issue presently blocking #5278.