(Needs Review) implements directly_contains_one association #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyingzumwalt
force-pushed
the
directly_contains_one_association
branch
from
aaa7b7d
to
befdee5
Compare
|
@jcoyne @terrellt I'm not in love with this code, but I need this feature in order to proceed with samvera/hydra-works#131 |
|
Looks like this depends on #794? So should we wait until that is fixed? |
|
|
| super | ||
|
|
||
| if !options[:has_member_relation] && !options[:is_member_of_relation] | ||
| raise ArgumentError, "You must specify a predicate for #{name}" |
There was a problem hiding this comment.
This error message is a bit misleading. Can is say, specify has_member_relation or is_member_of_relation?
flyingzumwalt
force-pushed
the
directly_contains_one_association
branch
2 times, most recently
from
116aff7
to
2ce78fd
Compare
Note: part of this functionality is blocked by #794
flyingzumwalt
force-pushed
the
directly_contains_one_association
branch
from
2ce78fd
to
9746594
Compare
jcoyne
added a commit
that referenced
this pull request
Jun 24, 2015
…iation (Needs Review) implements directly_contains_one association
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: part of this functionality is blocked by #794