Remove Skydrive support

Skydrive has become onedrive. Unclear if this is still useful, so removing it. The skydrive gem and its dependencies are unmaintained.
samvera · May 31, 2017 · de39e05 · de39e05
1 parent 322c8dc
commit de39e05
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 220 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -64,12 +64,10 @@ Rails/OutputSafety:
 Rails/TimeZone:
   Exclude:
     - 'lib/browse_everything/driver/google_drive.rb'
-    - 'lib/browse_everything/driver/sky_drive.rb'
     - 'lib/browse_everything/retriever.rb'
     - 'spec/unit/browse_everything_helper_spec.rb'
     - 'spec/unit/file_entry_spec.rb'
     - 'spec/unit/retriever_spec.rb'
-    - 'spec/unit/sky_drive_spec.rb'
     - 'spec/views/browse_everything/_file.html.erb_spec.rb'
 
 # Offense count: 3
@@ -96,7 +94,6 @@ Style/FileName:
 Style/GuardClause:
   Exclude:
     - 'lib/browse_everything/driver/google_drive.rb'
-    - 'lib/browse_everything/driver/sky_drive.rb'
 
 # Offense count: 1
 Style/MultilineBlockChain:
@@ -109,22 +106,6 @@ Style/MultilineBlockLayout:
   Exclude:
     - 'spec/unit/dropbox_spec.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: symmetrical, new_line, same_line
-Style/MultilineHashBraceLayout:
-  Exclude:
-    - 'spec/unit/sky_drive_spec.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: aligned, indented, indented_relative_to_receiver
-Style/MultilineMethodCallIndentation:
-  Exclude:
-    - 'spec/unit/sky_drive_spec.rb'
-
 # Offense count: 1
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
 # NamePrefix: is_, has_, have_

diff --git a/README.md b/README.md
@@ -6,7 +6,7 @@
 
 This Gem allows your rails application to access user files from cloud storage.
 Currently there are drivers implemented for [Dropbox](http://www.dropbox.com),
-[Skydrive](https://skydrive.live.com/), [Google Drive](http://drive.google.com),
+[Google Drive](http://drive.google.com),
 [Box](http://www.box.com), [Amazon S3](https://aws.amazon.com/s3/),
 and a server-side directory share.
 
@@ -57,7 +57,7 @@ In `app/assets/javascripts/application.js` include jquery and the BrowseEverythi
 
 ### Adding Providers
 In order to connect to a provider like [Dropbox](http://www.dropbox.com),
-[Skydrive](https://skydrive.live.com/), [Google Drive](http://drive.google.com), or
+[Google Drive](http://drive.google.com), or
 [Box](http://www.box.com), you must provide API keys in _config/browse_everything_providers.yml_.  For info on how to edit this file, see [Configuring browse-everything](https://github.com/projecthydra/browse-everything/wiki/Configuring-browse-everything)
 
 ### Views

diff --git a/browse-everything.gemspec b/browse-everything.gemspec
@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'addressable', '~> 2.5'
   spec.add_dependency 'google_drive'
   spec.add_dependency 'dropbox-sdk', '>= 1.6.2'
-  spec.add_dependency 'skydrive'
   spec.add_dependency 'ruby-box'
   spec.add_dependency 'sass-rails'
   spec.add_dependency 'bootstrap-sass'

diff --git a/lib/browse_everything.rb b/lib/browse_everything.rb
@@ -12,7 +12,6 @@ module Driver
     autoload :Base,        'browse_everything/driver/base'
     autoload :FileSystem,  'browse_everything/driver/file_system'
     autoload :Dropbox,     'browse_everything/driver/dropbox'
-    autoload :SkyDrive,    'browse_everything/driver/sky_drive'
     autoload :Box,         'browse_everything/driver/box'
     autoload :GoogleDrive, 'browse_everything/driver/google_drive'
     autoload :S3,          'browse_everything/driver/s3'

diff --git a/lib/browse_everything/driver/sky_drive.rb b/lib/browse_everything/driver/sky_drive.rb
diff --git a/lib/generators/browse_everything/templates/browse_everything_providers.yml.example b/lib/generators/browse_everything/templates/browse_everything_providers.yml.example
@@ -18,6 +18,3 @@
 #   :app_secret: YOUR_AWS_S3_SECRET # explicitly here, or left out to use system-configured
 #   :region: YOUR_AWS_S3_REGION     # defaults.
 #   See https://aws.amazon.com/blogs/security/a-new-and-standardized-way-to-manage-credentials-in-the-aws-sdks/
-# sky_drive:
-#   :client_id: YOUR_MS_LIVE_CONNECT_CLIENT_ID
-#   :client_secret: YOUR_MS_LIVE_CONNECT_CLIENT_SECRET
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -60,10 +60,6 @@ def stub_configuration
                                  client_id: 'GoogleClientId',
                                  client_secret: 'GoogleClientSecret'
                                },
-                               'sky_drive' => {
-                                 client_id: 'SkyDriveClientId',
-                                 client_secret: 'SkyDriveClientSecret'
-                               },
                                's3' => {
                                  app_key: 'S3AppKey',
                                  app_secret: 'S3AppSecret',

diff --git a/spec/unit/sky_drive_spec.rb b/spec/unit/sky_drive_spec.rb