Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to first page for pdf images #120

Merged
merged 1 commit into from
Nov 21, 2016
Merged

Default to first page for pdf images #120

merged 1 commit into from
Nov 21, 2016

Conversation

awead
Copy link
Contributor

@awead awead commented Nov 17, 2016

One last tweak, I hope.

For the PDF thumbnail generation to be effective, users would need to add the layer: 0 directive to their application code, so instead let's just default it to the first layer if we're coming from a pdf. This also fixes another problem with thumbnails of office documents. Because we're passing a pdf to the image converter internally when we convert office documents to images, we won't need to specify a layer directive there either.

Alternatively, we could pass a layer directive to the image processor from the document processor, and leave the existing image processor code unchanged, but that would still leave existing implementations with the task of overriding their create_derivatives methods to pass that layer directive in for all their other pdfs.

This PR should make default hydra installations behave correctly, with multi-page PDFs and office documents converted to images using their first pages only, while allowing for specific layer directives should the user choose them.

@carolyncole carolyncole merged commit 264dc05 into master Nov 21, 2016
@carolyncole carolyncole deleted the layer-defaults branch November 21, 2016 18:35
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black PDFs.

Also add more class attributes to allow setting the options.

See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black PDFs.

Also add more class attributes to allow setting the options.

See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black PDFs.

Also add more class attributes to allow setting the options.

See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black PDFs.

Also add more class attributes to allow setting the options.

See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black PDFs.

Also add more class attributes to allow setting the options.

See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black PDFs.

Also add more class attributes to allow setting the options.

See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black PDFs.

Also add more class attributes to allow setting the options.

See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black PDFs.

Also add more class attributes to allow setting the options.

See samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black images; see samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120

Also add more class attributes to allow setting the options.
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black images; see samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120

Also add more class attributes to allow setting the options.
dunn added a commit to dunn/riiif that referenced this pull request Dec 11, 2017
Should fix black images; see samvera/hydra-derivatives#110 and samvera/hydra-derivatives#120

Also add more class attributes to allow setting the options.
dunn added a commit to dunn/riiif that referenced this pull request Dec 12, 2017
dunn added a commit to dunn/riiif that referenced this pull request Dec 14, 2017
jcoyne pushed a commit to sul-dlss/riiif that referenced this pull request Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants