Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where non-jpg document derivatives fail #185

Closed
wants to merge 1 commit into from
Closed

fixed bug where non-jpg document derivatives fail #185

wants to merge 1 commit into from

Conversation

gwiedeman
Copy link
Contributor

Before, in the documents processor, files would open from /tmp as a string, and then fail during IO.copy_stream in Hyrax here: https://github.com/samvera/hyrax/blob/master/app/services/hyrax/persist_derivatives.rb#L13

Now, it opens them as binary and works as intended.

@cjcolvar cjcolvar closed this Jul 4, 2021
@cjcolvar cjcolvar deleted the branch samvera:master July 4, 2021 19:21
@cjcolvar
Copy link
Member

cjcolvar commented Jul 4, 2021

@gwiedeman The Renaming Branch Working Group is in the process of renaming the default branch from master to main in Samvera and Samvera-Labs repos. This brings repositories into compliance with the Samvera Community Code of Conduct (https://samvera.atlassian.net/wiki/spaces/samvera/pages/405212316/Code+of+Conduct) and language recommendations (https://github.com/samvera/maintenance/blob/master/templates/CONTRIBUTING.md#language). Background on the renaming effort is available in the working group notes (https://samvera.atlassian.net/wiki/x/b5IYHg).

I just updated the default branch name for hydra-derivatives which had the side effect of closing your pull request. Please reopen this pull request targeting the main branch if it is still relevant. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants