Solr extract service now succeeds over SSL #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
requested changes
Jan 31, 2020
There was a problem hiding this comment.
@gwiedeman This looks to be a great PR. Have you signed a contributor license agreement? Before we can merge this PR, we need to have that document. See our wiki for more details.
|
@jeremyf I didn't, but I just sent one in. Thanks for looking at this. |
|
@gwiedeman I see that Richard Green has sent you an email. We have your iCLA, however, for reasons outlined in the email, we need to hold your application. |
|
@gwiedeman Based on the email from Richard Green, it looks like all CLAs are in order. Welcome aboard, and thank you for your contribution. And thank you also for your patience in walking through the CLA process. |
jeremyf
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Solr extract service started failing with
undefined method 'use_ssl=' for #<Net::HTTP::Post POST>after updating hyrax from 2.5.1 to 2.6.0. This was using ruby 2.4.1 with rails 5.1.6.2. It looks like this commit was the culprit: 35a6e71. I pasted the full sidekiq error below.It seems like the .use_ssl method should apply to
Net::HTTP.start, notNet::HTTP::Posthere: https://github.com/samvera/hydra-derivatives/blob/master/lib/hydra/derivatives/processors/full_text.rb#L37Net::HTTP.start Docs: https://ruby-doc.org/stdlib-2.6.5/libdoc/net/http/rdoc/Net/HTTP.html#method-i-use_ssl-3D.
It also has to be called before
Net::HTTP.start, instead of after. I think this fixes it, but I'm not sure if you want to patch it another way, as the multiple commits was from my inability to use git revert correctly.FYI, this repo also contains #185, so that maybe should be looked at as well, but I think there was some uncertainly over fixing it on the Hyrax-side or hydra-derivatives side.
"""
2019-11-01T16:12:56.135Z 5342 TID-1e9wk6 CreateDerivativesJob JID-5649220ad1e560a1644e1f2c INFO: start
2019-11-01T16:13:00.001Z 5342 TID-1e9wk6 CreateDerivativesJob JID-5649220ad1e560a1644e1f2c INFO: fail: 3.866 sec
2019-11-01T16:13:00.002Z 5342 TID-1e9wk6 WARN: {"context":"Job raised exception","job":{"class":"ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper","wrapped":"CreateDerivativesJob","queue":"default","args":[{"job_class":"CreateDerivativesJob","job_id":"3fc5eb95-1944-4a1b-8b5f-1a9bdd2b8fbc","provider_job_id":null,"queue_name":"default","priority":null,"arguments":[{"_aj_globalid":"gid://hyrax/FileSet/gb19fq470"},"gb19fq470/files/d4191965-0fa9-4960-ac4d-f5995bdc30e1","/media/Library/ESPYderivatives/files/ua435/01 Brochure/beer game insert 01.doc"],"executions":0,"locale":"en"}],"retry":true,"jid":"5649220ad1e560a1644e1f2c","created_at":1572622086.4895666,"enqueued_at":1572624776.1350782,"error_message":"undefined method
use_ssl=' for #<Net::HTTP::Post POST>","error_class":"NoMethodError","failed_at":1572622090.4100199,"retry_count":6,"retried_at":1572623437.676636},"jobstr":"{\"class\":\"ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper\",\"wrapped\":\"CreateDerivativesJob\",\"queue\":\"default\",\"args\":[{\"job_class\":\"CreateDerivativesJob\",\"job_id\":\"3fc5eb95-1944-4a1b-8b5f-1a9bdd2b8fbc\",\"provider_job_id\":null,\"queue_name\":\"default\",\"priority\":null,\"arguments\":[{\"_aj_globalid\":\"gid://hyrax/FileSet/gb19fq470\"},\"gb19fq470/files/d4191965-0fa9-4960-ac4d-f5995bdc30e1\",\"/media/Library/ESPYderivatives/files/ua435/01 Brochure/beer game insert 01.doc\"],\"executions\":0,\"locale\":\"en\"}],\"retry\":true,\"jid\":\"5649220ad1e560a1644e1f2c\",\"created_at\":1572622086.4895666,\"enqueued_at\":1572624776.1350782,\"error_message\":\"undefined methoduse_ssl=' for #<Net::HTTP::Post POST>","error_class":"NoMethodError","failed_at":1572622090.4100199,"retry_count":6,"retried_at":1572623437.676636}"}2019-11-01T16:13:00.002Z 5342 TID-1e9wk6 WARN: NoMethodError: undefined method
use_ssl=' for #<Net::HTTP::Post POST> 2019-11-01T16:13:00.002Z 5342 TID-1e9wk6 WARN: /usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/processors/full_text.rb:37:inblock in http_request'/usr/local/rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/net/http.rb:877:in
start' /usr/local/rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/net/http.rb:608:instart'/usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/processors/full_text.rb:35:in
http_request' /usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/processors/full_text.rb:25:infetch'/usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/processors/full_text.rb:18:in
extract' /usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/processors/full_text.rb:7:inprocess'/usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/runners/runner.rb:30:in
block (2 levels) in create' /usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/runners/runner.rb:27:ineach'/usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/runners/runner.rb:27:in
block in create' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/hyrax-2.6.0/app/services/hyrax/local_file_service.rb:7:incall'/usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/runners/runner.rb:41:in
source_file' /usr/local/rvm/gems/ruby-2.4.1@hyrax/bundler/gems/hydra-derivatives-1c87e962d5bc/lib/hydra/derivatives/runners/runner.rb:26:increate'/var/www/hyrax-UAlbany/app/services/hyrax/file_set_derivatives_service.rb:111:in
extract_full_text' /var/www/hyrax-UAlbany/app/services/hyrax/file_set_derivatives_service.rb:74:increate_office_document_derivatives'/var/www/hyrax-UAlbany/app/services/hyrax/file_set_derivatives_service.rb:25:in
create_derivatives' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/hyrax-2.6.0/app/models/concerns/hyrax/file_set/derivatives.rb:51:increate_derivatives'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/hyrax-2.6.0/app/jobs/create_derivatives_job.rb:11:in
perform' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/execution.rb:37:inblock in perform_now'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:108:in
block in run_callbacks' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/i18n-1.7.0/lib/i18n.rb:297:inwith_locale'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/translation.rb:7:in
block (2 levels) in <module:Translation>' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:117:ininstance_exec'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:117:in
block in run_callbacks' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/logging.rb:24:inblock (4 levels) in module:Logging'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/notifications.rb:166:in
block in instrument' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/notifications/instrumenter.rb:21:ininstrument'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/notifications.rb:166:in
instrument' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/logging.rb:23:inblock (3 levels) in module:Logging'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/logging.rb:44:in
block in tag_logger' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/tagged_logging.rb:69:inblock in tagged'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/tagged_logging.rb:26:in
tagged' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/tagged_logging.rb:69:intagged'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/logging.rb:44:in
tag_logger' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/logging.rb:20:inblock (2 levels) in module:Logging'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:117:in
instance_exec' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:117:inblock in run_callbacks'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:135:in
run_callbacks' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/execution.rb:33:inperform_now'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/execution.rb:22:in
block in execute' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:108:inblock in run_callbacks'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/railtie.rb:26:in
block (4 levels) in <class:Railtie>' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/execution_wrapper.rb:85:inwrap'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/reloader.rb:68:in
block in wrap' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/execution_wrapper.rb:81:inwrap'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/reloader.rb:67:in
wrap' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/railtie.rb:25:inblock (3 levels) in class:Railtie'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:117:in
instance_exec' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:117:inblock in run_callbacks'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/callbacks.rb:135:in
run_callbacks' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/execution.rb:20:inexecute'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activejob-5.1.6.2/lib/active_job/queue_adapters/sidekiq_adapter.rb:40:in
perform' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:187:inexecute_job'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:169:in
block (2 levels) in process' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:128:inblock in invoke'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/middleware/chain.rb:133:in
invoke' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:168:inblock in process'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:139:in
block (6 levels) in dispatch' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/job_retry.rb:98:inlocal'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:138:in
block (5 levels) in dispatch' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/rails.rb:42:inblock in call'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/execution_wrapper.rb:85:in
wrap' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/reloader.rb:68:inblock in wrap'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/execution_wrapper.rb:85:in
wrap' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/activesupport-5.1.6.2/lib/active_support/reloader.rb:67:inwrap'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/rails.rb:41:in
call' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:134:inblock (4 levels) in dispatch'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:199:in
stats' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:129:inblock (3 levels) in dispatch'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/job_logger.rb:8:in
call' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:128:inblock (2 levels) in dispatch'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/job_retry.rb:73:in
global' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:127:inblock in dispatch'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/logging.rb:48:in
with_context' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/logging.rb:42:inwith_job_hash_context'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:126:in
dispatch' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:167:inprocess'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:85:in
process_one' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/processor.rb:73:inrun'/usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/util.rb:16:in
watchdog' /usr/local/rvm/gems/ruby-2.4.1@hyrax/gems/sidekiq-5.1.3/lib/sidekiq/util.rb:25:inblock in safe_thread'"""