Skip to content

Commit

Permalink
Merge e1722c0 into d8dcbe9
Browse files Browse the repository at this point in the history
  • Loading branch information
jcoyne committed Jul 16, 2018
2 parents d8dcbe9 + e1722c0 commit 5e3c65c
Show file tree
Hide file tree
Showing 3 changed files with 68 additions and 58 deletions.
59 changes: 3 additions & 56 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,57 +1,4 @@
require: rubocop-rspec
inherit_gem:
bixby: bixby_default.yml

AllCops:
DisplayCopNames: true
Include:
- '**/Rakefile'

Metrics/LineLength:
Enabled: false

Metrics/AbcSize:
Max: 17

Style/CollectionMethods:
PreferredMethods:
collect: 'map'
collect!: 'map!'
inject: 'reduce'
detect: 'find'
find_all: 'select'

Style/ClassAndModuleChildren:
Enabled: false

Style/Documentation:
Enabled: false

RSpec/ExampleWording:
CustomTransform:
be: is
have: has
not: does not
NOT: does NOT
IgnoredWords:
- only

RSpec/FilePath:
Enabled: false

RSpec/InstanceVariable:
Enabled: false

RSpec/NamedSubject:
Enabled: false

RSpec/MultipleExpectations:
Exclude:
- spec/hydra/pcdm/collection_indexer_spec.rb
- spec/hydra/pcdm/pcdm_indexer_spec.rb
- spec/hydra/pcdm/models/*

RSpec/ExampleLength:
Exclude:
- spec/hydra/pcdm/models/*

RSpec/NestedGroups:
Enabled: false
inherit_from: .rubocop_todo.yml
64 changes: 64 additions & 0 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2018-07-16 07:38:44 -0500 using RuboCop version 0.52.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 29
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/BlockLength:
Max: 527

# Offense count: 1
# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
Naming/FileName:
Exclude:
- '**/Gemfile'
- '**/*.rake'
- 'Capfile'
- 'config/deploy/*'
- 'hydra-pcdm.gemspec'

# Offense count: 7
# Configuration parameters: Max.
RSpec/ExampleLength:
Exclude:
- 'spec/hydra/pcdm/models/collection_spec.rb'
- 'spec/hydra/pcdm/models/object_spec.rb'

# Offense count: 69
# Configuration parameters: AssignmentOnly.
RSpec/InstanceVariable:
Exclude:
- 'spec/hydra/pcdm/models/collection_spec.rb'
- 'spec/hydra/pcdm/models/object_spec.rb'

# Offense count: 199
RSpec/NamedSubject:
Exclude:
- 'spec/hydra/pcdm/collection_indexer_spec.rb'
- 'spec/hydra/pcdm/models/collection_spec.rb'
- 'spec/hydra/pcdm/models/file_spec.rb'
- 'spec/hydra/pcdm/models/object_spec.rb'
- 'spec/hydra/pcdm/object_indexer_spec.rb'
- 'spec/hydra/pcdm/pcdm_indexer_spec.rb'

# Offense count: 1
# Configuration parameters: Max.
RSpec/NestedGroups:
Exclude:
- 'spec/hydra/pcdm/models/object_spec.rb'

# Offense count: 10
# Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters:
Exclude:
- 'spec/hydra/pcdm/collection_indexer_spec.rb'
- 'spec/hydra/pcdm/models/collection_spec.rb'
- 'spec/hydra/pcdm/models/object_spec.rb'
- 'spec/hydra/pcdm/object_indexer_spec.rb'
- 'spec/hydra/pcdm/pcdm_indexer_spec.rb'
3 changes: 1 addition & 2 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
source 'https://rubygems.org'

group :development, :test do
gem 'rubocop', '~> 0.46.0', require: false
gem 'rubocop-rspec', '~> 1.9.1', require: false
gem 'bixby', '~> 1.0'
gem 'pry' unless ENV['CI']
gem 'pry-byebug' unless ENV['CI']
end
Expand Down

0 comments on commit 5e3c65c

Please sign in to comment.