Overhauled Docker Configuration #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangewolf
changed the title
orangewolf
force-pushed
the
docker-updates
branch
from
34fe872
to
93ba2fd
Compare
orangewolf
changed the title
jpengst
previously approved these changes
Apr 26, 2019
kellyChex
previously approved these changes
Apr 26, 2019
…side Docker This commit is in preperation of beginning to release docker images that can be used via Docker Hub with each new release. It also allows for fully dockerized development environment and production environments. Two phase Docker build - base and main. The goal here are much faster build times by moving seldom changing items to the base image. Moves to Passenger base image which allows a few real niceties: - for dev, you can restart the web process w/o restarting the container, saving a lot of time - for prod passenger is more effecient by default in a variety of configurations than puma. Puma frequenty requires more tuning - means nginx is serving assets, so no extra proxy is required Note, this makes the build a little bigger, but with libreoffice and fits in there this change is a pretty small fraction in my opinion. Uses a nulldb to compile assets during build, making deployment much faster. Also set up to allow for optional assets volume, which makes keeping cached assets possible This Dockerfile moves fits to always be in the same place in the container. There is still a version file present, so we don't really need it in the path and that means we don't have to update multiple places when we change versions. Just in the Dockerfile.base Sets the admin and default host in dockerfile and virtual_host attributes. That allows this setup to work in dev by default with common proxies like Dory and others. Makes test adjustments to allow for Docker environment, adds an external Chrome driver docker container to the dev environment Splits the production and dev docker-compose.yml files. Reduced dev zookeeper to 1, removed lb and memcached from dev. Splitting futher refinement of production docker-compose in to a seperate task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is in preparation of beginning to release Docker images that can be used via Docker Hub with each new release. It also allows for fully dockerized development environment and production environments.
Two phase Docker build - base and main. The goal here are much faster build times by moving seldom changing items to the base image.
Moves to Passenger base image which allows a few real niceties:
Note, this makes the build a little bigger, but with libreoffice and fits in there this change is a pretty small fraction in my opinion.
Uses a nulldb to compile assets during build, making deployment much faster. Also set up to allow for optional assets volume, which makes keeping cached assets possible
This Dockerfile moves fits to always be in the same place in the container. There is still a version file present, so we don't really need it in the path and that means we don't have to update multiple places when we change versions. Just
in the Dockerfile.base
Sets the admin and default host in dockerfile and virtual_host attributes. That allows this setup to work in dev by default with common proxies like Dory and others.
Makes test adjustments to allow for Docker environment, adds an external Chrome driver docker container to the dev environment
Splits the production and dev docker-compose.yml files. Reduced dev zookeeper to 1, removed lb and memcached from dev. Splitting futher refinement of production docker-compose in to a seperate task as part of #1577.
Fixes #1562 ; refs #1577
@samvera/hyrax-code-reviewers