Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-worker-script-executable-update-dockerfile-cmd #1843

Merged
merged 3 commits into from
Jan 9, 2023
Merged

add-worker-script-executable-update-dockerfile-cmd #1843

merged 3 commits into from
Jan 9, 2023

Conversation

aprilrieger
Copy link
Collaborator

Contributing back

  • Adds worker script with helpful developer hints.
  • This script has been chmod +x
  • The Dockerfile has been updated to call the script CMD ./bin/worker
  • And removes CMD bundle exec sidekiq

orangewolf
orangewolf reviewed Jan 8, 2023
View reviewed changes
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rubocop fixes

@aprilrieger
Copy link
Collaborator Author

@orangewolf Ready for your review!

alishaevn
alishaevn approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@alishaevn alishaevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@aprilrieger aprilrieger merged commit 5a5e022 into main Jan 9, 2023
@bkiahstroud bkiahstroud deleted the add-worker-script-executable-update-dockerfile-cmd branch February 1, 2023 01:05
@bkiahstroud bkiahstroud added the patch-ver for release notes label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangewolf orangewolf orangewolf left review comments

@alishaevn alishaevn alishaevn approved these changes

Assignees
No one assigned
Labels
patch-ver for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aprilrieger @orangewolf @alishaevn @bkiahstroud