add conditional to account for when iiif print gem is installed #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alishaevn
previously approved these changes
Jan 10, 2023
kirkkwang
force-pushed
the
update-iiifmanifestpresenterdecorator
branch
from
3f1984f
to
fe5ff1e
Compare
|
@alishaevn i had to pull |
alishaevn
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all the work going in the IIIF Print gem, we need a way to safely override methods. Instead of updating the
IiifManifestPresenterDecoratorwith a injections from a generator, the safer approach is to checksuperto see if there's another implementation of it, in our case, coming from the IIIF Print gem. If not then carry on as usual.