Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Introduce Hyku::Application.theme_view_path_roots #2007

Merged
merged 1 commit into from
Dec 13, 2023

Commits on Dec 13, 2023

  1. ♻️ Introduce Hyku::Application.theme_view_path_roots

    With the introduction of [HykuKnapsack][1], we are adjusting how we
    create instances of Hyku.  Namely we don't clone Hyku but instead we
    incorporate Hyku as a submodule into a Knapsack.
    
    The Knapsack is a Rails engine that is mounted in the Hyku application.
    What this means is that when we want to
    
    Prior to this commit, the only way to adjust themed views would have
    been to add them to the Rails application (e.g. Hyku) directly.  Which
    would work in a non-Knapsack ecosystem.
    
    However, with Knapsack we need a means of saying "Hey, for themes we
    want to be able to add/adjust views within the knapsack."  Hence this
    change.
    
    [1]: https://github.com/samvera-labs/hyku_knapsack
    jeremyf committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    31de0fe View commit details
    Browse the repository at this point in the history