encoding bug of " for non-default language

[jmfrenzel]

Descriptive summary

encoding bug of „ “ for German language

Expected behavior

Übertragung des Eigentums von „Fedora“

Guillemets are preferred in German. I started to correct this earlier in https://github.com/samvera/hyrax/pull/2443/files
So #3421 requests to display all quotations as for example: https://nurax-dev.curationexperts.com/concern/generic_works/gm80hv50h/edit?locale=de
... im Abschnitt „Freigeben“ einen bestimmten ...

Actual behavior

https://nurax-dev.curationexperts.com/works/hd76s024f/transfers/new?locale=de

Steps to reproduce the behavior

1. https://nurax-dev.curationexperts.com/works/hd76s024f/transfers/new?locale=de

Related work

Link to related tickets or prior related work here.

[jmfrenzel]

Changed description, see:
#3476 (comment)

[jmfrenzel]

German locale
should display „Fedora“

English locale

[cjcolvar]

Was this fixed by #3767?

[jmfrenzel]

No it wasn't.
The template does not render correctly, see

hyrax/app/views/hyrax/transfers/new.html.erb

Line 2 in 3af966f

<h1><span class="fa fa-arrows-h" aria-hidden="true"></span><%= t(:'.title', work_title: @proxy_deposit_request.to_s) %></h1>

This is the line in the German locale being affected.

hyrax/config/locales/hyrax.de.yml

Line 1181 in 3af966f

title: Übertragung des Eigentums von „%{work_title}“

To me I seems the is with the variable %{work_title}

The other non working rendering is the help text on the same page

hyrax/config/locales/hyrax.de.yml

Line 1180 in 3af966f

sr_only_description: Wählen Sie einen Benutzer aus, um „%{work_title}“ zu senden, fügen Sie optionale Kommentare hinzu und drücken Sie dann Übertragung.

[fritzfreiheit]

I think a general solution to this problem would be to allow for html characters to remain html characters when processed by I18n.translate, rather than replace strings like '„' with '„'.

Edit: further research reveals... see below.

[fritzfreiheit]

@jmfrenzel -- I did some research into this, and it turns out that the I18n.translate mechanism accepts hex and unicode escapes, so you can do this (note the double quotes are necessary):

title: "\xDCbertragung des Eigentums von \u201E%{work_title}\u201D"

Produces:

Übertragung des Eigentums von „Der Titel

Given the above, I assume the German yaml files can be updated to produce the desired quote characters without resorting programming. I'm not sure how the internationalization files are updated, but we could either change this ticket to do the updates for all quotes in the German yaml translation files, or a new ticket could be opened to review and do the updates (which may need more than the quote punctuations updated).

Note: Unicode translations were found here: https://www.quackit.com/character_sets/unicode/general_punctuation_unicode_character_codes.cfm

[jmfrenzel]

@fritzfreiheit since hyrax will deliver utf-8 what if in the yaml we explicitly use "„ " and "“" ? This would more convenient to maintain. Could you test this? I don't have a dev instance at hand.

[fritzfreiheit]

@jmfrenzel -- Yes, I just tried it on my development instance of Hyrax, and the explicit use of utf-8 characters worked.

[kellyChex]

Confirmed the quotations are showing