use explicit utf-8 character for German Guillemets' #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use of utf-8 is a good solution to this issue. I've checked this on in my local development environment (Mac OSX and Chrome) and the appropriate punctuation us produced in the browser. |
|
Sorry didn't mean to close this. |
fritzfreiheit
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3421
Guillemets are preferred in German.
Changes proposed in this pull request:
"for non-default language #3421 )Guidance for testing, such as acceptance criteria or new user interface behaviors:
"for non-default language #3421@samvera/hyrax-code-reviewers