-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File count in collections panel of admin dashboard tops out at 10 #446
Comments
@jcoyne Ooops. Sorry. Using the feature test, I found it is the number of works returned with the query that tops out at 10 rather than file count. A fix would be to add a large row count to the query at https://github.com/projecthydra-labs/hyrax/blob/master/app/services/hyrax/admin_set_service.rb#L33 . Say |
Yeah, I think loading 10k rows would be pretty expensive, and even then wouldn't be big enough. We have 3m objects. |
@jcoyne I began exploring this, but didn't spend too much time on it. I think we'll need to cache the admin_set_id in the solr document for the file. Also, given the gnarly nature of the graphs and caching, I'm wondering if it would be helpful to look to the Curate::Indexer for graph indexing (https://github.com/ndlib/curate-indexer) |
It's honestly not terribly clear to me what the files column is meant to show. In Nurax, most collections show 0 files: In demo.curationexperts.com, the count for the one existing admin set exceeds 10: @vantuyls @samvera/hyrax-repo-managers What's the value of this column? Can we clarify what we are counting? |
meant to count the number of files in the admin set. Not sure if something isn't wired up properly right now - it is clearly not counting all files in the admin set, there. |
@no-reply @vantuyls yeah it's definitely not reporting correctly for # files on nurax. I can see this feature being useful if it was working. Does it seem to be working here? https://nurax.curationexperts.com/dashboard/my/collections?locale=en /my/collections seems like it is a more useful place for this reporting. "dashboard" is not a place linked from the left admin menu and so one must go to top right dropdown or navigate via dashboard. Therefore I don't see this view being accessed as much as /my/collections. Also direct URL /dashboard results in an error. :/ |
Ok, i've looked at this on our system at OSU and on Nurax and here is what i'm seeing:
|
cc @andjsmit This was what I was worried about ☝️
The text was updated successfully, but these errors were encountered: