Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File count in collections panel of admin dashboard tops out at 10 #446

Closed
jcoyne opened this issue Feb 17, 2017 · 7 comments
Closed

File count in collections panel of admin dashboard tops out at 10 #446

jcoyne opened this issue Feb 17, 2017 · 7 comments

Comments

@jcoyne
Copy link
Member

jcoyne commented Feb 17, 2017

screen shot 2017-02-17 at 5 09 29 pm

cc @andjsmit This was what I was worried about ☝️

@andjsmit
Copy link
Contributor

andjsmit commented Feb 21, 2017

@jcoyne Ooops. Sorry. Using the feature test, I found it is the number of works returned with the query that tops out at 10 rather than file count. A fix would be to add a large row count to the query at https://github.com/projecthydra-labs/hyrax/blob/master/app/services/hyrax/admin_set_service.rb#L33 . Say rows: 10_000. Would this be too much of a performance hit to be an acceptable solution?

@jcoyne
Copy link
Member Author

jcoyne commented Feb 21, 2017

Yeah, I think loading 10k rows would be pretty expensive, and even then wouldn't be big enough. We have 3m objects.

@jeremyf jeremyf assigned jeremyf and unassigned jeremyf Mar 2, 2017
jeremyf added a commit that referenced this issue Mar 2, 2017
@jeremyf
Copy link
Contributor

jeremyf commented Mar 2, 2017

@jcoyne I began exploring this, but didn't spend too much time on it. I think we'll need to cache the admin_set_id in the solr document for the file.

Also, given the gnarly nature of the graphs and caching, I'm wondering if it would be helpful to look to the Curate::Indexer for graph indexing (https://github.com/ndlib/curate-indexer)

@no-reply
Copy link
Member

no-reply commented Jun 9, 2018

It's honestly not terribly clear to me what the files column is meant to show. In Nurax, most collections show 0 files:

nurax_files

In demo.curationexperts.com, the count for the one existing admin set exceeds 10:

tenejo_files

@vantuyls @samvera/hyrax-repo-managers What's the value of this column? Can we clarify what we are counting?

@vantuyls
Copy link

meant to count the number of files in the admin set. Not sure if something isn't wired up properly right now - it is clearly not counting all files in the admin set, there.

@julesies
Copy link

@no-reply @vantuyls yeah it's definitely not reporting correctly for # files on nurax. I can see this feature being useful if it was working. Does it seem to be working here? https://nurax.curationexperts.com/dashboard/my/collections?locale=en

/my/collections seems like it is a more useful place for this reporting. "dashboard" is not a place linked from the left admin menu and so one must go to top right dropdown or navigate via dashboard. Therefore I don't see this view being accessed as much as /my/collections.

Also direct URL /dashboard results in an error. :/

@no-reply no-reply added this to Backlog in Hyrax WG -- Sprint 1 via automation Jul 2, 2018
@vantuyls vantuyls moved this from Backlog to Ready in Hyrax WG -- Sprint 1 Jul 10, 2018
@vantuyls
Copy link

vantuyls commented Jul 12, 2018

Ok, i've looked at this on our system at OSU and on Nurax and here is what i'm seeing:

  1. File counts are not accurate, though it is entirely unclear what is being counted. I see numbers from 0 to 10 in that column, all of which are inaccurate
  2. I'm unable to replicate the error @julesies reports about the direct link ./dashboard throwing an error

@kdid kdid moved this from Ready to In progress in Hyrax WG -- Sprint 1 Jul 16, 2018
@kdid kdid self-assigned this Jul 16, 2018
@kdid kdid moved this from In progress to Review in Hyrax WG -- Sprint 1 Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

8 participants