Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rights field should be single-valued by default, and overrideable #90

Closed
mjgiarlo opened this issue Dec 21, 2016 · 12 comments
Closed

Rights field should be single-valued by default, and overrideable #90

mjgiarlo opened this issue Dec 21, 2016 · 12 comments

Comments

@mjgiarlo
Copy link
Member

Issue by awead
Thursday Aug 20, 2015 at 01:34 GMT
Originally opened as samvera-deprecated/sufia#1287


@mjgiarlo
Copy link
Member Author

Comment by jcoyne
Thursday Aug 20, 2015 at 14:09 GMT


I'm not sure this is always true. Probably for the 99% though.

@mjgiarlo
Copy link
Member Author

Comment by mjgiarlo
Thursday Aug 20, 2015 at 17:55 GMT


I suspect it's always true for folks who aren't overriding any of the select values for that field. And if they're already overriding that... 😄

I don't think it makes any sense to let folks select multiple CC licenses, or to select a CC license and "All rights reserved." The default select values suggest single-valued field to me.

@mjgiarlo
Copy link
Member Author

Comment by vantuyls
Thursday Aug 27, 2015 at 19:41 GMT


The only places I've seen someone assign multiple (CC) licenses to an object, I'm pretty sure they screwed up. I've been racking my brain for the past week trying to think of a case where one could actually assign multiple CC licenses and i've come up with nothing.

@mjgiarlo
Copy link
Member Author

Comment by jcoyne
Friday Aug 28, 2015 at 01:44 GMT


Yes, my exception case was licenses from the library, not CC licenses.

@mjgiarlo
Copy link
Member Author

Comment by mjgiarlo
Monday Aug 31, 2015 at 22:14 GMT


I spent a day or two hacking on this but I need to move onto other things.

@mjgiarlo
Copy link
Member Author

Comment by vantuyls
Monday Aug 31, 2015 at 22:15 GMT


Hrm. We just made this happen locally.

@mjgiarlo
Copy link
Member Author

Comment by mjgiarlo
Monday Aug 31, 2015 at 22:18 GMT


Maybe the magic incantation is in here: osulp/Scholars-Archive@746e02a

Thanks for the heads-up, @vantuyls

@straleyb if you want to toss a fix upstream, that'd be great!

@mjgiarlo
Copy link
Member Author

Comment by straleyb
Monday Aug 31, 2015 at 22:20 GMT


Yeah, I'll update and send a PR. If not this afternoon, tomorrow morning. 👍

@mjgiarlo
Copy link
Member Author

Comment by vantuyls
Monday Aug 31, 2015 at 22:20 GMT


INTERNET!

@mjgiarlo
Copy link
Member Author

Comment by mjgiarlo
Monday Aug 31, 2015 at 22:21 GMT


👏 🎆 @vantuyls @straleyb

@mjgiarlo
Copy link
Member Author

Comment by mjgiarlo
Friday Sep 11, 2015 at 17:18 GMT


Are you still interested in working on this @straleyb?

@mjgiarlo
Copy link
Member Author

Comment by mjgiarlo
Monday Dec 14, 2015 at 22:05 GMT


Paging @straleyb and @vantuyls. :)

If you are interested in contributing this work back, please do issue the PR against the 6.x-stable branch.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant