increase the number of AdminSets rendered on #index

[revgum]

by default, when visiting the AdminSet #index view, the number of rows rendered is limited to 10. The select list for adjusting viewable rows in the table is not intending on making a request of the server for more/less rows, it just adjusts the visible rows and pagination on the page.

This patch increased the default number of rows to be rendered so that the table is capable of rendering and paginating up to 100 AdminSets.

I don't think this is the best long term solution for this issue, however it does somewhat fall in line with how this is done in the CollectionSearchBuilder. https://github.com/samvera/hyrax/blob/master/app/search_builders/hyrax/collection_search_builder.rb

[jcoyne]

Is it possible to scope this change to AdminSetService#search_results_with_work_count ?

[revgum]

In the case I was addressing (/admin/admin_sets?locale=en) #search_results_with_work_count isn't involved. The request comes in by way of: https://github.com/samvera/hyrax/blob/master/app/controllers/hyrax/admin/admin_sets_controller.rb#L36

[jcoyne]

Okay, AdminSetService#search_results then?

[revgum]

I had thought about that as well but went with this approach to be consistent with the CollectionSearchBuilder.. So are you thinking,

hyrax/app/services/hyrax/admin_set_service.rb

Line 18 in da079af

response = context.repository.search(builder(access))

:

response = context.repository.search(builder(access, 100))

and then setting @rows as an argument in AdminSetSearchBuilder.initialize?

[jcoyne]

I do not think we should set @rows at all if we can avoid it. We can do AdminSetSearchBuilder.new.rows(100) instead. That's how you're supposed to use that API.

[jcoyne]

@revgum see #1221