Fix ordering of headlines on Dashboard landing page #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1961
This fixes the noted accessibility issue of using header elements which are out of order in page flow. For example:
Here are a few screenshots of what the fixes look like, which visually look odd (at least to me), since the
<h1>and<h2>elements have been styled to be the same size.@no-reply @vantuyls @jcoyne Perhaps some future work for this group could be establishing a better consistency in the UI for how we're handling page titles, sub-titles, and so forth. Maybe go through the whole site and just clean it up and make consistent. I'd volunteer for this.
@samvera/hyrax-code-reviewers