New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release date issue in Safari #4067
Conversation
f5a66d0
to
cab3b80
Compare
According to the coveralls report, code coverage is reduced in |
we're okay to ignore coveralls. there's a proposal to remove it altogether since it does this constantly. GitHub is setup to not require it, but still produces the scary red X. Merge on this is just blocked by a review. Hoping someone with frontend expertise can take a peek at this. cc: @adamjarling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, thank you very much for this @Dananji! A quick question: why was var
used in place of let
here for ES6? My assumption is that the former is preferred: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let#Temporal_dead_zone
|
||
var $form = $('form'); | ||
$form.on('submit', function() { | ||
var data = $(this).serializeArray(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @jrgriffiniii.. for any es6/es7
JavaScript lets stick with either let
or const
variable declarations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I will make that change
Code looks good to me. |
cab3b80
to
64c7549
Compare
Fixes #4005
When editing admin sets in Safari, the embargo release date format shows up as yyyy-mm-dd and is not able to save dates in the format mm/dd/yyyy (expected format) sometimes.
Changes proposed in this pull request:
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Release and Visibility
tab10/23/2025
and save@samvera/hyrax-code-reviewers