[wings] Avoid special handling for values in ConverterValueMapper
#4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor `Wings::ConverterValueMapper` to use the `::Valkyrie::ValueMapper` chain in place of all prior special handling. Where we used to delete attributes manually, now we capture and return `nil` for them during conversion. This helps clarify the classes of special behavior that we have, and opens the door to refined handling for edge cases. Remove the `ActiveFedoraAttributes#filter_attributes` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Wings::ConverterValueMapperto use the::Valkyrie::ValueMapperchain in place of all prior special handling. Where we used to delete attributes
manually, now we capture and return
nilfor them during conversion.This helps clarify the classes of special behavior that we have, and opens the
door to refined handling for edge cases.
Remove the
ActiveFedoraAttributes#filter_attributesmethod.Changes proposed in this pull request:
@samvera/hyrax-code-reviewers