Deprecate PowerConverter
#4097
Merged
Deprecate PowerConverter
#4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2019 11:57
`PowerConverter` is a community-maintained gem, but is not in the Samvera namespace. Depending on it under these circumstances is not in keeping with our policy. Rather than simply inline the `PowerConverter` class, this proposes pushing in the direction a more generic ruby pattern that inspired it. http://devblog.avdi.org/2012/05/07/a-ruby-conversion-idiom/
Allow `WorkflowAction` to handle casting to an action name, using `.name_for(object_to_cast)`.
no-reply
force-pushed
the
deprecate-pc
branch
from
df03819
to
e5d1dfb
Compare
no-reply
changed the title
PowerConverter based to_sipity_actionPowerConverter
no-reply
force-pushed
the
deprecate-pc
branch
3 times, most recently
from
f4c1ef3
to
cba1ce5
Compare
added 5 commits
October 18, 2019 16:42
This was very sparsely used. Instead of porting it elsewhere, just cast the one caller individually. If folks are using this downstream (I'd guess they aren't) we could consider putting this mapper at the top `Hyrax` level, or somewhere similar.
no-reply
force-pushed
the
deprecate-pc
branch
from
2bf081d
to
e8f4f94
Compare
jcoyne
approved these changes
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerConverteris a community-maintained gem, but is not in the Samveranamespace. Depending on it under these circumstances is not in keeping with our
policy.
Rather than simply inline the
PowerConverterclass, this proposes pushing inthe direction a more generic ruby pattern that inspired
it. http://devblog.avdi.org/2012/05/07/a-ruby-conversion-idiom/
MyClass(thing_to_cast_from), as is done in Ruby core..*_formethod as a factoryRefs #4096
@samvera/hyrax-code-reviewers