Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard accessibility issues #4152

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Fix dashboard accessibility issues #4152

merged 1 commit into from
Jan 17, 2020

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Nov 7, 2019

Fixes #3964

Improve accessibility of the dashboard, using axe to assess the accessibility of the elements in the page.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Install the Axe plugin or addon from Deque (https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ is the firefox version).
  • Login as an admin user
  • Go to the dashboard
  • Open dev tools and go to axe tab
  • Click 'Analyze'
  • Logout and login again as a normal user
  • Open dev tools and go to axe tab
  • Click 'Analyze'

@samvera/hyrax-code-reviewers

@Dananji Dananji marked this pull request as ready for review November 8, 2019 17:08
blancoj
blancoj previously requested changes Dec 3, 2019
Copy link
Contributor

@blancoj blancoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Resubmit to get rid of failing test.

@stale
Copy link

stale bot commented Jan 2, 2020

This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

@stale stale bot added the stale label Jan 2, 2020
@stale stale bot closed this Jan 16, 2020
@no-reply no-reply reopened this Jan 16, 2020
@stale stale bot removed the stale label Jan 16, 2020
@no-reply no-reply dismissed blancoj’s stale review January 17, 2020 04:33

there's no need to resubmit. the Circle builds can be kicked to rerun from failed jobs in case of intermittent failures

@no-reply no-reply merged commit cee85f2 into master Jan 17, 2020
@no-reply no-reply deleted the issue-3964 branch January 17, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard accessibility audit
3 participants