Use Valkyrie::ID<=>String equality #4264
Conversation
Valkyrie 2.1.0 overhauld ID equality as a feature-flag change, with the new behavior to become default in 3.0.0. Turning it on preemtively for Hyrax will save us and adopters a lot of trouble going forward.
|
Hold this pending a resolution to samvera/valkyrie#820 |
no-reply
changed the title
|
I like! 👍 |
|
do you think we need to hold this until a release with some fix for samvera/valkyrie#820, or should we roll forward now and let the valkyrie fix come in its own time? |
|
@no-reply Given the caveat that you posted about |
|
This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions. |
|
bumping this |
no-reply
changed the title
There was a problem hiding this comment.
Given that Hyrax requires Valkyrie ~> 2.1, this will work. However, since the upstream commit is thusfar only in 2.1.1, I believe the gemspec should be altered to reflect that range. Otherwise, we're relying on an implementer to run bundle update valkyrie on their branch.
I'm adding a commit to reflect that.
For this PR to work for upstream adopters, we need to ensure that our gemspec includes the [upstream Valkyrie commit][1]. From the valkyrie repository, I ran: ```console $ git tag --contains 343656c78411cc0788a8f723f8332d2e697213fe => v2.1.1 ``` [1]:samvera/valkyrie@343656c
|
@no-reply I added another commit to this. For the record, I approve of your commit. Narrowing Valkyrie dependency rangeFor this PR to work for upstream adopters, we need to ensure that our From the valkyrie repository, I ran: $ git tag --contains 343656c78411cc0788a8f723f8332d2e697213fe
=> v2.1.1 |
Valkyrie 2.1.0 overhauled ID equality as a feature-flag change, with the new
behavior to become default in 3.0.0. Turning it on preemptively for Hyrax will
save us and adopters a lot of trouble going forward.
@samvera/hyrax-code-reviewers