extend MembershipHelper and ResourceForm for member_ids
#4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a `MembershipHelper#work_members_json` with support for legacy forms as well as valkyrie resources. extend `ResourceForm` to add support for `member_ids`.
|
I like this direction. It starts breaking apart large objects, factoring that behavior into a helper. Yes…we could pursue an object to wrap the extract behavior, but for now this disentangles the issues. I'd like others to weigh in. We discussed this in Samvera Tech call 2020-05-20 |
jeremyf
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a
MembershipHelper#work_members_jsonwith support for legacy forms as wellas valkyrie resources. extend
ResourceFormto add support formember_ids.@samvera/hyrax-code-reviewers