Generate metadata yaml with fields passed as arguments to generator #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really like where this is going. Ping me when the tests are passing and I'll do a formal review. |
then use this metadata configuration in the generated form, indexer, and model by default.
jeremyf
approved these changes
May 29, 2020
This was referenced May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate metadata yaml with fields passed as arguments to generator then use this metadata configuration in the generated form, indexer, and model by default. If no fields are passed to the generator then the generated metadata configuration is an empty hash of attributes and doesn't have any affect but doesn't break anything.
Should there be any tests for this other than using it in the generated internal test app?
Second PR split out from #4342.