Better model resolution for wings #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
better-model-resolution
branch
2 times, most recently
from
81f57ee
to
e010702
Compare
jeremyf
reviewed
Jun 8, 2020
jeremyf
reviewed
Jun 8, 2020
jeremyf
reviewed
Jun 8, 2020
no-reply
force-pushed
the
better-model-resolution
branch
2 times, most recently
from
a65bf02
to
a611662
Compare
jeremyf
previously approved these changes
Jun 12, 2020
since we introduced proper handling for valkyrie models without AF equivalents, we've been casting Valkyrie models to `DefaultWork` directly in the `ActiveFedoraConverter`. this is a bit fragile, since anything that looks them up (like the `Wings::WorkSearchBuilder`), is going to miss in the registry, leaking `nil` about where folks might see it! instead, let the registry handle resolution to the appropriate class even in case of misses. this points to a further refactor, extracting (and probably renaming) `DefaultWork` from `Wings::ActiveFedoraConverter`, since it's no longer (and never really was) neatly encapsulated there. this fixes an intermittent failure in the test suite.
no-reply
force-pushed
the
better-model-resolution
branch
from
a611662
to
f436668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we introduced proper handling for valkyrie models without AF equivalents,
we've been casting Valkyrie models to
DefaultWorkdirectly in theActiveFedoraConverter. this is a bit fragile, since anything that looks themup (like the
Wings::WorkSearchBuilder), is going to miss in the registry,leaking
nilabout where folks might see it! instead, let the registry handleresolution to the appropriate class even in case of misses.
this points to a further refactor, extracting (and probably renaming)
DefaultWorkfromWings::ActiveFedoraConverter, since it's no longer (andnever really was) neatly encapsulated there.
this fixes an intermittent failure in the test suite.
@samvera/hyrax-code-reviewers