update NestedCollectionPersistenceService to use CollectionMemberService #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since CollectionMemberService publishes `'object.metadata.updated'` and message published wants to attribute the action to a user, the persistence service methods added a `user:` parameter which defaults to nil for backwards compatibility. Callers of these methods within Hyrax code were updated to pass a user or updated to call CollectionmemberService directly to avoid having to create an instance of the parent collection.
no-reply
requested changes
Aug 17, 2021
spec/services/hyrax/collections/nested_collection_persistence_service_spec.rb
Outdated
Show resolved
Hide resolved
spec/services/hyrax/collections/nested_collection_persistence_service_spec.rb
Outdated
Show resolved
Hide resolved
spec/services/hyrax/collections/nested_collection_persistence_service_spec.rb
Outdated
Show resolved
Hide resolved
Setting the relationship of nested collections through Valkyrie resources in the CollectionMemberService requires that the parent collection have an id assigned to be able to store the id in the child. The previous approach through AF took care of establishing the relationship.
elrayle
force-pushed
the
wings/5071_mem_of_cols
branch
from
37fd5ae
to
41794ac
Compare
…service_spec.rb To support lazy loading with enumerables, it is better to check for empty. Co-authored-by: tamsin johnson <tomjohnson@ucsb.edu>
…service_spec.rb Co-authored-by: tamsin johnson <tomjohnson@ucsb.edu>
…service_spec.rb Co-authored-by: tamsin johnson <tomjohnson@ucsb.edu>
no-reply
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CollectionMemberService publishes
'object.metadata.updated'and message published wants to attribute the action to a user, the persistence service methods added auser:parameter which defaults to nil for backwards compatibility. Callers of these methods within Hyrax code were updated to pass a user or updated to call CollectionmemberService directly to avoid having to create an instance of the parent collection.Partially addresses #5071
@samvera/hyrax-code-reviewers