provide NullUser for use when real user is not available #5077
Conversation
Primary usage is to provide backward compatibility for methods adding a `user:` parameter. Whenever possible, a real user should be passed to methods with `user: NullUser.new` parameter.
| # @return [nil] | ||
| def id | ||
| '_NULL_USER_ID_' | ||
| end |
There was a problem hiding this comment.
Any concerns having a fake id? The tests do not pass if #id returns nil.
ERROR:
Unable to serialize Hyrax::NullUser without an id. raised in ContentUpdateEventJob.perform_later when running the specs for NestedCollectionPersistenceService.
There was a problem hiding this comment.
link_to_profile depositor the eventual caller? i think including a broken id is going to (best case) cause a broken link. worse, i think with a real adapter ActiveJob is going to serialize/deserialize a GlobalID, which will fail on the deserialization, preventing the job from running.
i think we might need to consider passing a real user. there are various system users by default. we could use one of those or make a new one.
There was a problem hiding this comment.
Do you have a suggestion for the 'real' user to pass? This impacts PR #5083 as well. I temporarily used ::User.audit_user for that PR. I am happy to drop the NullUser if there is a viable alternative.
|
Replaced by PR #5087 add system user. |
Primary usage is to provide backward compatibility for methods adding a
user:parameter. Whenever possible, a real user should be passed to methods withuser: NullUser.newparameter.Updates usage of
user: niladded in PR #5076@samvera/hyrax-code-reviewers