refactor collection members controller specs #5160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
refactor-collection-members-cont-tests
branch
from
c368ed3
to
5d28462
Compare
these specs were really challenging to read, had a lot of duplication and had many specs with multiple expectations. this provides clearer naming, consistent indentation style, and deduplicated parameters. it also removes much unneeded setup code (e.g. providing cryptic ids and titles for each example object).
no-reply
force-pushed
the
refactor-collection-members-cont-tests
branch
from
8f47f40
to
2ad78d5
Compare
let the factories take care of any 'other' depositors.
no-reply
force-pushed
the
refactor-collection-members-cont-tests
branch
2 times, most recently
from
6a85920
to
846db37
Compare
switch many of the factory generated objects for these tests to valkyrie. the level of compatibility demonstrated here is pretty interesting!
mcritchlow
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these specs were really challenging to read, had a lot of duplication and
had many specs with multiple expectations.
this provides clearer naming, consistent indentation style, and deduplicated
parameters. it also removes much unneeded setup code (e.g. providing cryptic ids
and titles for each example object).
interestingly, though the tests here are split out, these seem to run quite a bit faster.
once this is in, i'm hoping to further refactor the whole file to take advantage of valkyrie's
in-memory adapter and further speed up test times.
@samvera/hyrax-code-reviewers