characterize valkyrie file uploads #5278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter.upload and waits to save the file_metadata until after upload The wings convertor for the the valkyrie FileMetadata now sets the content of the converted ActiveFedora::File object
dunn
force-pushed
the
valkyrie-characterization
branch
from
9d0a0f4
to
5c6d6b1
Compare
|
closing while i rethink this a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds characterization metadata to
Hyrax::FileMetadatafor whatever setters it has defined that match the terms extracted by fits.this is accomplished by
ValkyrieUploadsHandlerto circumvent the current pipeline that makes many AF assumptions (this means that the Valkyrie logic inJobIOWrapperis dead code now)object.file.uploaded(distinct fromobject.metadata.updatedbecause characterization should not run every time metadata is chaged)ValkyrieCharacterizationServiceto execute fits and attach the metadata (currently runs synchronously, but making it run as a job may be added as acceptance criteria)this does not yet teach Hyrax how to display characterization information in the UI.
@samvera/hyrax-code-reviewers