set and index permissions for admin sets #5421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Addresses #5408
There are several issue preventing admin sets from being listed on Dashboard -> Collections.
valkyrie_create
method in the controller did not pass the user to the transaction creating permissionsThe first 3 are fixed in this PR. The last part of the search build issue is not complete. See Remaining Work below.
Remaining Work
There is still an outstanding issue with the query to retrieve collections and admin sets.
Old Query:
This includes adding the
Hyrax::AdministrativeSet
to the set of models"{!terms f=has_model_ssim}AdminSet,Hyrax::AdministrativeSet,Hyrax::PcdmCollection"
, but the part that limits admin sets to the current user being the creator does not includeHyrax::AdministrativeSet
. I wasn't able to come to a syntax for the query that would allow the model for this part of the query to beAdminSet
ORHyrax::AdministrativeSet
.(_query_:\"{!raw f=has_model_ssim}AdminSet\" AND _query_:\"{!raw f=creator_ssim}****@hotmail.com\")
Attempt at a New Query (doesn't work):
@samvera/hyrax-code-reviewers