use configured admin_set_class to test admin_set? in solr doc #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #5408
PR #5421, PR #5422, PR #5423, PR #5424 were all related to producing and querying a solr doc so that admin sets appeared in the list of collections on Dashboard -> Collections.
Once they were in the list, their links were not correct. The links were created using the collection routes instead of admin set routes. This was happening because the
SolrDocumentfor admin sets was always returnfalsefor#admin_set?. And this was happening because the method#admin_set?was checking for class::AdminSet. This PR updates the method to check for classHyrax.config.admin_set_class. This config defaults toAdminSetallowing for backward compatibility. And allows for valkyrie apps (e.g. nurax-pg) which are configured toHyrax::AdministrativeSetsto correctly identify admin sets.@samvera/hyrax-code-reviewers