Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyrax-5471 - Works in mediated workflow not listed as managed works f… #5473

Conversation

fritzfreiheit
Copy link
Contributor

@fritzfreiheit fritzfreiheit commented Feb 28, 2022

Works in mediated workflow not listed as managed works for user with managing role

Fixes #5471

This issue stemmed from investigation into issue: #5436

Add code to search builders to filter for admin sets with user's managing role.

Update [app/search_builders/hyrax/dashboard/managed_search_filters.rb] to add a method that performs the following steps:

  • Find the managing sippity role
  • convert the current user into a sippity agent
  • from the agent's list of workflow responsibilities, find all responsibilities that are managing
  • with this list of workflow responsibilities, find the corresponding admin set ids through the corresponding permission templates
  • add a list of search filters that include "isPartOf" admin set ids identified in prior step

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • (1) Ensure that an admin set with a one-step mediated workflow exists.
  • (2) As a normal user, create a work and add the admin set with a one-step mediated workflow identified or created in step 1.
  • (3) Grant a non-admin user managing status to the admin set with the one-step mediated workflow used in step 2.
  • (4) Go to the Dashboard, then Works page of a non-admin user with managing status from step 3.
  • (5) The Managed User tab should be visible. Go to that tab.
  • (6) The work created in step 2 should be listed in this tab. (It should also be listed in the Review Submissions tab.)

@samvera/hyrax-code-reviewers

@dlpierce dlpierce merged commit d7d847e into main Mar 2, 2022
@dlpierce dlpierce deleted the hyrax-5471-works-in-mediated-workflow-not-listed-as-managed-works-for-user-with-managing-role branch March 2, 2022 18:14
@jlhardes
Copy link
Contributor

jlhardes commented Mar 3, 2022

This seems to be better for non-admin users with managing roles on mediated workflow admin sets. The admin user I can see on nurax-dev is still not seeing the full list of works in the Review Submissions section in the Under Review tab but the All Works tab shows a long list of works under review so this overall does seem to be an improvement. I am calling this a win and we'll see if there are other issues to figure out around the admin user view of mediated works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Works in mediated workflow not listed as managed works for user with managing role
3 participants