Don't setup event tracking or attempt any tracking if analytics provider is not on page #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der is not on page This change fixes a bug when the page does not have an analytics provider setup. In this scenario TrackingTags.analytics() assumes Google analytics and then errors because _gaq is undefined. This error keeps all subsequent JS from executing. This causes the refreshing of CSRF tokens on turbolinks:load not to run and many forms to raise InvalidAuthenticityToken.
elrayle
approved these changes
Mar 14, 2022
|
This bug bit us, thanks very much for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug when the page does not have an analytics provider setup. In
this scenario TrackingTags.analytics() assumes Google analytics and then errors because
_gaq is undefined. This error keeps all subsequent JS from executing. This causes the
refreshing of CSRF tokens on turbolinks:load not to run and many forms to raise
InvalidAuthenticityToken.
Fixes #5464 and #5470
@samvera/hyrax-code-reviewers