Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes date modified formatting and adds guards for nil values #5526

Closed
wants to merge 1 commit into from

Conversation

sdellis
Copy link
Contributor

@sdellis sdellis commented Mar 14, 2022

Fixes #5525 ; refs #5490

This PR formats the dates properly, provides a "date_added" fallback when "date_modified" is nil, and guards against nil values in the _list_works.html.erb view.

An alternate approach was suggested which involves creating a new solar field, "last_change" (or something like that) which would provide the date_modified or date_added if the resource was not modified.

The preferred approach can be debated on this PR in the comments.

@samvera/hyrax-code-reviewers

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions.

@stale stale bot added the stale label Apr 17, 2022
@stale stale bot closed this May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Works Dashboard Date Modified should be formatted as YYYY-MM-DD
1 participant