Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio and video playback through valkyrie codepaths #6297

Merged
merged 3 commits into from Sep 7, 2023

Conversation

hackartisan
Copy link
Contributor

@hackartisan hackartisan commented Sep 6, 2023

closes #6294
closes #6227

@samvera/hyrax-code-reviewers

Screen.Recording.2023-09-06.at.5.19.04.PM.mov

@hackartisan hackartisan added this to Ready for Review in Hyrax-Valkyrization Sep 6, 2023
@eliotjordan eliotjordan force-pushed the gh-6294-derivatives-use branch 2 times, most recently from 893f597 to a4f0200 Compare September 7, 2023 15:41
hackartisan and others added 3 commits September 7, 2023 10:41
closes #6294

Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com>
Co-authored-by: Eliot Jordan <eliotjordan@users.noreply.github.com>
Co-authored-by: Shaun Ellis <sdellis@users.noreply.github.com>
@hackartisan hackartisan changed the title Save derivative pcdm_use when creating derivatives via valkyrie Fix audio and video playback through valkyrie codepaths Sep 7, 2023
@tpendragon tpendragon merged commit 94c8066 into main Sep 7, 2023
4 checks passed
@tpendragon tpendragon deleted the gh-6294-derivatives-use branch September 7, 2023 18:03
@eliotjordan eliotjordan moved this from Ready for Review to QA in Hyrax-Valkyrization Sep 7, 2023
@rjkati rjkati moved this from QA to DONE in Hyrax-Valkyrization Sep 7, 2023
@dlpierce dlpierce added the notes-valkyrie Release Notes: Valkyrie specific label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-valkyrie Release Notes: Valkyrie specific
Projects
5 participants