Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valkyrie audio files have wrong mime type, derivatives have the wrong pcdm_use #6294

Closed
hackartisan opened this issue Sep 5, 2023 · 1 comment · Fixed by #6297
Closed

Valkyrie audio files have wrong mime type, derivatives have the wrong pcdm_use #6294

hackartisan opened this issue Sep 5, 2023 · 1 comment · Fixed by #6297
Assignees
@hackartisan
Labels
valkyrization

Comments

@hackartisan
Copy link
Contributor

Descriptive summary

When I run derivatives on an mp3 or a wav file, I get 2 derivatives, both with use ThumbnailImage and both with mime_type application/octet-stream. They should have use ServiceFile and mime_types should be:

  • for mp3: audio/mpeg
  • for ogg: audio/ogg

Also the original file has mime_type audio/x-wave even though it's an mp3.

When the original file is a wav, it also gets audio/x-wave however it should be either audio/wav or audio/x-wav with no 'e'.
@hackartisan hackartisan mentioned this issue Sep 5, 2023
Closed
@hackartisan hackartisan self-assigned this Sep 6, 2023
hackartisan pushed a commit that referenced this issue Sep 6, 2023
@tpendragon @eliotjordan
@sdellis @hackartisan
Add correct mime type to a/v derivatives
3fe3ab0 
By saving mime type passed to ValkyriePersistDerivatives
advances gh-6294

Co-authored-by: Eliot Jordan <eliotjordan@users.noreply.github.com>
Co-authored-by: Shaun Ellis <sdellis@users.noreply.github.com>
Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com>
@hackartisan hackartisan mentioned this issue Sep 6, 2023
Merged
tpendragon added a commit that referenced this issue Sep 6, 2023
@hackartisan @tpendragon
@eliotjordan @sdellis
Add correct mime type to a/v derivatives (#6296)
28b32fb 
By saving mime type passed to ValkyriePersistDerivatives
advances gh-6294

Co-authored-by: Trey Pendragon <tpendragon@princeton.edu>
Co-authored-by: Eliot Jordan <eliotjordan@users.noreply.github.com>
Co-authored-by: Shaun Ellis <sdellis@users.noreply.github.com>
Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com>
@hackartisan
Copy link
Contributor Author

Ignoring the mis-characterized original for now; open a new ticket for that if needed.

@hackartisan hackartisan reopened this Sep 6, 2023
hackartisan added a commit that referenced this issue Sep 6, 2023
@hackartisan @tpendragon
@eliotjordan @sdellis
Save derivative pcdm_use when creating derivatives via valkyrie
f9b2fd0 
closes #6294

Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com>
Co-authored-by: Eliot Jordan <eliotjordan@users.noreply.github.com>
Co-authored-by: Shaun Ellis <sdellis@users.noreply.github.com>
@hackartisan hackartisan mentioned this issue Sep 6, 2023
Merged
hackartisan added a commit that referenced this issue Sep 6, 2023
@hackartisan @tpendragon
@eliotjordan @sdellis
Save derivative pcdm_use when creating derivatives via valkyrie
6163f25 
closes #6294

Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com>
Co-authored-by: Eliot Jordan <eliotjordan@users.noreply.github.com>
Co-authored-by: Shaun Ellis <sdellis@users.noreply.github.com>
eliotjordan added a commit that referenced this issue Sep 6, 2023
@hackartisan @tpendragon
@eliotjordan @sdellis
Save derivative pcdm_use when creating derivatives via valkyrie
655d7a0 
closes #6294

Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com>
Co-authored-by: Eliot Jordan <eliotjordan@users.noreply.github.com>
Co-authored-by: Shaun Ellis <sdellis@users.noreply.github.com>
eliotjordan added a commit that referenced this issue Sep 7, 2023
@hackartisan @tpendragon
@eliotjordan @sdellis
Save derivative pcdm_use when creating derivatives via valkyrie
57abee7 
closes #6294

Co-authored-by: Trey Pendragon <tpendragon@users.noreply.github.com>
Co-authored-by: Eliot Jordan <eliotjordan@users.noreply.github.com>
Co-authored-by: Shaun Ellis <sdellis@users.noreply.github.com>
tpendragon pushed a commit that referenced this issue Sep 7, 2023
@hackartisan
Fix audio and video playback through valkyrie codepaths (#6297)
94c8066 
* Save derivative pcdm_use when creating derivatives via valkyrie

closes #6294

* allowed mime_type to be passed to find file metadata

* Correctly pass mime_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackartisan hackartisan

Labels
valkyrization
Projects
Hyrax-Valkyrization
Status: DONE
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix audio and video playback through valkyrie codepaths samvera/hyrax
1 participant
@hackartisan